Add index error handling #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may want to include the full response inside the throw (new ElasticException(
sprintf('%s: %s', $error['type'], $error['reason'])
))->setResponse($response);try {
// ...
} catch (ElasticException $e) {
$e->getResponse();
} |
|
Hey, @stevebauman thank you for the PR! This is a known issue, I was hoping that it gets resolved on elasticsearch client side, but as more people face the issue, it makes sense to resolve it in the adapter. I was working on a similar approach, but never pushed it until now (see v1.16.1). You can update the composer and start catching custom try {
// ...
} catch (BulkRequestException $e) {
$response = $e->getResponse();
} |
|
Ah perfect @babenkoivan! Thanks for pushing an update! Really appreciate it 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds an exception to be thrown when an index response contains errors.
Description
I discovered after a couple hours of troubleshooting why my indexing wasn't working with my custom mapping using elastic-migrations. I had to jump into my vendor directory and dump the response ES was replying back with, but unfortunately no errors are handled, logged, or returned.
Without any error handling, I can't use this package in production, as my indexing may suddenly stop working and I won't have any knowledge of its failure without enabling some sort of logging mechanism inside of ElasticSearch itself.
References
This PR abides by ElasticSearch's outlined response body for bulk operations.
https://www.elastic.co/guide/en/elasticsearch/reference/master/docs-bulk.html#bulk-api-response-body
Let me know if you would like anything adjusted or have any comments/criticisms of this PR. I'm all for abiding by whatever style you would like 👍
Thanks!